Fix JMX Exporter container port spec #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdaberdaku
force-pushed
the
main
branch
2 times, most recently
from
09a36f5 to
f4cb34d
Compare
nineinchnick
approved these changes
Sep 19, 2024
nineinchnick
changed the title
|
Dear @nineinchnick, Thank you for your review. Please let me know if you have any more comments. Best, S. |
nineinchnick
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the JMX Exporter container port to correct container (previously located on the coordinator container), with a minor.
Also, the property
.Values.jmx.exporter.configPropertieswas declared as a list which was incorrect. I converted it to a templated multiline string.I also updated the minimal JMX configuration example in the default value of
.Values.jmx.exporter.configProperties.Fixes #221